Fix Combobox issue when using virtual mode
#3734
Merged
+22
−319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
philipp-spiess
approved these changes
May 20, 2025
DAcodedBEAT
approved these changes
May 20, 2025
And JSDOM doesn't support this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the
Comboboxcomponent when using thevirtualmode.We recently already fixed this issue (#3678) by applying a patch on the
@tanstack/virtual-corepackage. But this was only applied in cjs builds, not in the esm builds.Instead of trying to fix it in our build process, we decided to just fix it upstream (TanStack/virtual#1004) and this PR bumps the version of
@tanstack/virtual-coreto the latest version (which includes the fix).