Fix Listbox not focusing first or last option on ArrowUp/ArrowDown
#3721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we were opening the listbox in a `flushSync()` call, after that call we were focusing the first or last option depending on if you used the ArrowDown or ArrowUp keys. However, the options can and will be registered at a later point, which means that the focus of first or last option is technically going to fail because no options are available yet. With this fix we don't need the `flushSync` call, and instead we passthrough a pending focus. Once the options are registered, if a pending focus is present, only then will we focus the correct option. This gets rid of timing issues.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where if a Listbox does not have a value yet, and it's opened via an ArrowUp or ArrowDown (on the ListboxButton) then it didn't correctly go to the firs or last option.
Before, we were opening the listbox in a
flushSync()call, after that call we were focusing the first or last option depending on if you used the ArrowDown or ArrowUp keys.However, the options can and will be registered at a later point in time, which means that the focus of first or last option is technically going to fail because no options are available yet.
With this fix we don't need the
flushSynccall, and instead we passthrough a pending focus. Once the options are registered, if a pending focus is present, only then will we focus the correct option.This gets rid of timing issues.