-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated DialogBackdrop
and DialogOverlay
components
#3171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
force-pushed
the
remove-old-deprecated-components
branch
from
May 3, 2024 14:03
9ef269f
to
778e5c7
Compare
reinink
changed the title
Remove
Remove deprecated May 3, 2024
DialogBackdrop
and DialogOverlay
componentsDialogBackdrop
and DialogOverlay
components
We deprecated those components in v1.6, since they are no longer documented and this is a major release, we can safely get rid of it.
RobinMalfait
force-pushed
the
remove-old-deprecated-components
branch
from
May 3, 2024 14:08
778e5c7
to
ca27167
Compare
Can we also remove |
Hey @tchanxx, we re-introduced it in v2.1.0, which is useful in combination with the new |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We deprecated those components in v1.6, since they are no longer documented and this is a major release, we can safely get rid of it.
If you still run into this, you should be able to replace the
<DialogOverlay>
and<DialogBackdrop>
components with a simple<div>
instead.Or