Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only render virtual options wrapper when there are items to show #3161

Merged
merged 2 commits into from
May 1, 2024

Conversation

thecrypticace
Copy link
Contributor

With this change you'll be able to use the empty:hidden class to hide the combobox options when there are no options visible in both virtualized and normal comboboxes.

Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headlessui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 1:55pm
headlessui-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 1:55pm

@thecrypticace thecrypticace merged commit db702a7 into main May 1, 2024
8 checks passed
@thecrypticace thecrypticace deleted the fix/remove-wrapper-when-no-virtual-options branch May 1, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants