Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t unmount portal targets used by other portals #3144

Merged
merged 4 commits into from
Apr 26, 2024

Conversation

thecrypticace
Copy link
Contributor

Because of a timing issue we were unmounting the portal root when the open portals changed within the same tick. This PR keeps track of how many portals are using a given portal root and makes sure it is not unmounted until there are no more portals using it.

Fixes #3116
Fixes #2933

Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headlessui-react ❌ Failed (Inspect) Apr 26, 2024 4:24pm
headlessui-vue ❌ Failed (Inspect) Apr 26, 2024 4:24pm

@thecrypticace thecrypticace merged commit 1724106 into 1.x Apr 26, 2024
6 of 8 checks passed
@thecrypticace thecrypticace deleted the fix/dont-remove-reused-portal-tagets branch April 26, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants