Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure hidden TabPanel components are hidden from the accessibility tree #2708

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Ensure hidden TabPanel components are hidden from the accessibility tree #2708

merged 2 commits into from
Aug 28, 2023

Commits on Aug 28, 2023

  1. explicitly add the aria-hidden="true" attribute 

    The `Hidden` component only adds the `aria-hidden` by default if the
`Focusable` feature is passed. In our case we don't want it to be
focusable so therefore we didn't pass this feature flag.

Because we didn't pass the `Focusable` feature, the `display: hidden`
was used which makes it completely unfocusable to the keyboard of the
user which is what we want.

However, the VoiceOver cursor _can_ get into those elements. Adding the
`aria-hidden` manually to these tabs solves the issue.
    @RobinMalfait
    RobinMalfait committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    5a66af9 View commit details
    Browse the repository at this point in the history

  2. update changelog

    @RobinMalfait
    RobinMalfait committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    1edb114 View commit details
    Browse the repository at this point in the history