-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure FocusTrap
is only active when the given enabled
value is true
#2456
Ensure FocusTrap
is only active when the given enabled
value is true
#2456
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@milhamm is attempting to deploy a commit to the Tailwind Labs Team on Vercel. A member of the Team first needs to authorize it. |
Tabs
that contains a Dialog
Tabs
that contains a Dialog
Tabs
that contains a Dialog
This will allow us to make the code relatively similar between React and Vue.
Tabs
that contains a Dialog
FocusTrap
is only active when the given enabled
value is true
Hey, thanks so much for this contribution! 🙏 While your fix worked as expected, there was a bigger problem going on where the I also ported the fix + test to the Vue version. The added test was very helpful, thanks! |
Hey @RobinMalfait, thanks for sorting out the root cause of the problem. Quick question: would it be okay if I also update the |
Currently, the tab focus is wrong when navigating on a
Tab
containing aDialog
component.Previous Behavior
Screencast.from.04-26-2023.04.22.32.PM.webm
This PR Fix
Screencast.from.04-26-2023.04.23.58.PM.webm
Fixes #2406