-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple new components #220
Commits on Feb 11, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8494bd5 - Browse repository at this point
Copy the full SHA 8494bd5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 07f9167 - Browse repository at this point
Copy the full SHA 07f9167View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8648052 - Browse repository at this point
Copy the full SHA 8648052View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1d98d7d - Browse repository at this point
Copy the full SHA 1d98d7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 97011bb - Browse repository at this point
Copy the full SHA 97011bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4943d02 - Browse repository at this point
Copy the full SHA 4943d02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5c293b8 - Browse repository at this point
Copy the full SHA 5c293b8View commit details
Commits on Feb 12, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a52f2e3 - Browse repository at this point
Copy the full SHA a52f2e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for a1ed110 - Browse repository at this point
Copy the full SHA a1ed110View commit details -
Configuration menu - View commit details
-
Copy full SHA for dec4049 - Browse repository at this point
Copy the full SHA dec4049View commit details -
Configuration menu - View commit details
-
Copy full SHA for 370d3bc - Browse repository at this point
Copy the full SHA 370d3bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 40f1bc6 - Browse repository at this point
Copy the full SHA 40f1bc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 222f7d5 - Browse repository at this point
Copy the full SHA 222f7d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for c4e953b - Browse repository at this point
Copy the full SHA c4e953bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d1d332f - Browse repository at this point
Copy the full SHA d1d332fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a0becc - Browse repository at this point
Copy the full SHA 4a0beccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 108c2f0 - Browse repository at this point
Copy the full SHA 108c2f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bc6a6d - Browse repository at this point
Copy the full SHA 2bc6a6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bb2148c - Browse repository at this point
Copy the full SHA bb2148cView commit details -
This will allow us to mark everything but the current ref as "inert". This is important for screenreaders, to ensure that screenreaders and assistive technology can't interact with other content but the current ref. This implementation is not ideal yet. It doesn't take into account that you can use the hook in 2 different components. For now this is fine, since we only use it in a Dialog and you should also probably only have a single Dialog open at a time. Will improve this in the future!
Configuration menu - View commit details
-
Copy full SHA for b912bf6 - Browse repository at this point
Copy the full SHA b912bf6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 301be38 - Browse repository at this point
Copy the full SHA 301be38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 61193d8 - Browse repository at this point
Copy the full SHA 61193d8View commit details -
ensure we respect autoFocus on form elements within the Dialog
If we have an autoFocus on an input, that input will receive focus. Once we try to focus the first focusable element in the Dialog this could be lead to unwanted behaviour. Therefore we check if the focus already is within the Dialog, if it is, keep it like that.
Configuration menu - View commit details
-
Copy full SHA for c2f723b - Browse repository at this point
Copy the full SHA c2f723bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6f665d9 - Browse repository at this point
Copy the full SHA 6f665d9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b2b8d1 - Browse repository at this point
Copy the full SHA 6b2b8d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 66e0dfd - Browse repository at this point
Copy the full SHA 66e0dfdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 575de8f - Browse repository at this point
Copy the full SHA 575de8fView commit details -
close Dialog when it becomes hidden
Could happen when this is in md:hidden for example
Configuration menu - View commit details
-
Copy full SHA for 1459bac - Browse repository at this point
Copy the full SHA 1459bacView commit details -
When we `Tab` in a FocusTrap it will try and focus the Next element. If we are in a state where none of the elements inside the FocusTrap can be focused, then we keep trying to focus the next one in line. This results in an infinite loop... To mitigate this issue, we check if we looped around, if we did, it means that we tried all the other focusable elements, therefore we can stop.
Configuration menu - View commit details
-
Copy full SHA for 7ff4dc3 - Browse repository at this point
Copy the full SHA 7ff4dc3View commit details -
isIntersecting doesn't work in every scenario
When page is scrollable, when dialog is translated of the page. Now just checking for sizes, which should be enough for md:hiden cases
Configuration menu - View commit details
-
Copy full SHA for 8628328 - Browse repository at this point
Copy the full SHA 8628328View commit details -
render Portal contents in a div
Otherwise you can't use multiple Portal components if you render multiple children inside each Portal
Configuration menu - View commit details
-
Copy full SHA for 64fed3f - Browse repository at this point
Copy the full SHA 64fed3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 75d05e5 - Browse repository at this point
Copy the full SHA 75d05e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ccd2e4a - Browse repository at this point
Copy the full SHA ccd2e4aView commit details
Commits on Feb 18, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 42dd9f7 - Browse repository at this point
Copy the full SHA 42dd9f7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8046055 - Browse repository at this point
Copy the full SHA 8046055View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ab53e4 - Browse repository at this point
Copy the full SHA 8ab53e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 983061d - Browse repository at this point
Copy the full SHA 983061dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 247ab32 - Browse repository at this point
Copy the full SHA 247ab32View commit details -
Configuration menu - View commit details
-
Copy full SHA for a5e197e - Browse repository at this point
Copy the full SHA a5e197eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8fce1f6 - Browse repository at this point
Copy the full SHA 8fce1f6View commit details -
actually call .focus() on the element
This ensures that the document.activeElement becomes the focused element.
Configuration menu - View commit details
-
Copy full SHA for bc4f7e9 - Browse repository at this point
Copy the full SHA bc4f7e9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9db527 - Browse repository at this point
Copy the full SHA b9db527View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5873f12 - Browse repository at this point
Copy the full SHA 5873f12View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05475f3 - Browse repository at this point
Copy the full SHA 05475f3View commit details -
fix regression while using outside click
There might be a chance that you didn't even notice this *bug*. The idea is that when you click outside, that the Menu or Listbox closes. However there is another step that happens: 1. When you click on a focusable item, keep the focus on that item. 2. When you click on a non-focusable item, move focus back to the Menu.Button or Listbox.Button We broke part 2, we never returned to the Menu.Button or Listbox.Button. This is (might) be important for screenreaders so that they don't "get lost", because if you click on a non-focusable item, the document.body becomes the active element. Confusing.
Configuration menu - View commit details
-
Copy full SHA for 2785733 - Browse repository at this point
Copy the full SHA 2785733View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8296ead - Browse repository at this point
Copy the full SHA 8296eadView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2aeaf1a - Browse repository at this point
Copy the full SHA 2aeaf1aView commit details