Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Transition component's incorrect cleanup and order of events #1803

Merged
merged 9 commits into from
Sep 1, 2022

Conversation

RobinMalfait
Copy link
Member

@RobinMalfait RobinMalfait commented Aug 31, 2022

This PR should fix a handful of issues where leave transitions weren't properly cleaning up
the DOM resulting in sometimes UI pages that feel "stuck", especially if you are using a Dialog
component that is technically still open now due to incorrect unmounting.

A lot of the Dialog components use fixed inset-0 which renders a div for the backdrop but since
that is sometimes still there and sitting on top of all other content, this results in the stuck
pages.

This PR should improve that, and therefore also fix some open issues:

Fixes: #1557
Fixes: #1638
Fixes: #1364
Closes: #1585 (this is a big, but incomplete rewrite of the Transition component; We can pick this up later if needed)

@vercel
Copy link

vercel bot commented Aug 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
headlessui-react ✅ Ready (Inspect) Visit Preview Sep 1, 2022 at 10:43PM (UTC)
headlessui-vue ✅ Ready (Inspect) Visit Preview Sep 1, 2022 at 10:43PM (UTC)

@RobinMalfait RobinMalfait changed the title Improve Transition component Fix Transition component's incorrect cleanup and order of events Sep 1, 2022
@RobinMalfait RobinMalfait changed the title Fix Transition component's incorrect cleanup and order of events Fix Transition component's incorrect cleanup and order of events Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant