Don't scroll lock when a Transition + Dialog is mounted but hidden #1681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In React we weren't using the current
show
state to determine the initial "visibility" of transitions which meant that an mounted but hidden Transition + a mounted but hiddenDialog
causes the document scroll lock to be applied when it shouldn't be because it's not being shown.Just something we missed ¯\_(ツ)_/¯
Fixes #1676