-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some render features + render strategy #106
Merged
Merged
Commits on Oct 15, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 8553808 - Browse repository at this point
Copy the full SHA 8553808View commit details -
Configuration menu - View commit details
-
Copy full SHA for 797e384 - Browse repository at this point
Copy the full SHA 797e384View commit details
Commits on Oct 17, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 766c45a - Browse repository at this point
Copy the full SHA 766c45aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4200bcf - Browse repository at this point
Copy the full SHA 4200bcfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1208e01 - Browse repository at this point
Copy the full SHA 1208e01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59c00d4 - Browse repository at this point
Copy the full SHA 59c00d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8edf821 - Browse repository at this point
Copy the full SHA 8edf821View commit details -
add ability to change the ref property using
refName
Example use case: ```tsx // Some components have this API with an `innerRef`. The suggested approach is to use // `React.forwardRef` so that you get the actual `ref` value. However if you already have this // `innerRef` API than we can use the `refName="innerRef"` to give the `ref` prop a good name. It // defaults to `ref` so that it still works everywhere else. function MyButton({ innerRef, ...props }) { return <button ref={innerRef} {...props} /> } <Menu.Button as={MyButton} refName="innerRef" /> ```
Configuration menu - View commit details
-
Copy full SHA for 68a2139 - Browse repository at this point
Copy the full SHA 68a2139View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f941bd - Browse repository at this point
Copy the full SHA 3f941bdView commit details -
add tests for the render abstraction (Render)
+ use the unique __ symbol as a default value in the Props type for the omitable props.
Configuration menu - View commit details
-
Copy full SHA for b0cb7a0 - Browse repository at this point
Copy the full SHA b0cb7a0View commit details
Commits on Oct 18, 2020
-
Configuration menu - View commit details
-
Copy full SHA for f65721a - Browse repository at this point
Copy the full SHA f65721aView commit details -
add/update Transition examples to also showcase the
unmount={false}
…… render strategy
Configuration menu - View commit details
-
Copy full SHA for da85aba - Browse repository at this point
Copy the full SHA da85abaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 726fe21 - Browse repository at this point
Copy the full SHA 726fe21View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f8b0d5 - Browse repository at this point
Copy the full SHA 7f8b0d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ff01b9 - Browse repository at this point
Copy the full SHA 2ff01b9View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.