chore: docker, copy binary from dist #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eneskaya
force-pushed
the
fix/docker-use-local-binary
branch
from
05f2595
to
4e8bd79
Compare
eneskaya
force-pushed
the
fix/docker-use-local-binary
branch
from
4e8bd79
to
d58607a
Compare
mlabouardy
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During
docker buildwe used to grab the binary from remote S3, which leaded to the Docker image sometimes not having the latest binary file. This PR changes the Dockerfile to copy the binary from the local /dist folder, which is always up to date after building.