client/web: add metric for exit node advertising #9781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates tailscale/corp#15215 Signed-off-by: Naman Sood <mail@nsood.in>
tendstofortytwo
force-pushed
the
naman/webclient-exitnode-metric
branch
from
238e615 to
c5f9103
Compare
willnorris
approved these changes
Oct 12, 2023
Updates #cleanup Signed-off-by: Naman Sood <mail@nsood.in>
soniaappasamy
approved these changes
Oct 12, 2023
Comment on lines
+69
to
+72
| var ( | ||
| exitNodeRouteV4 = netip.MustParsePrefix("0.0.0.0/0") | ||
| exitNodeRouteV6 = netip.MustParsePrefix("::/0") | ||
| ) |
There was a problem hiding this comment.
I wonder if we actually have these vars somewhere in a lib... But this is a nice update!
There was a problem hiding this comment.
we seem to have them at least 3 times in this repo. maybe the copy in net/netutil would be the best to export and reuse?
There was a problem hiding this comment.
maybe in a separate PR though, since @bradfitz might have opinions on exporting those long-term?
alexelisenko
pushed a commit
to Control-D-Inc/tailscale
that referenced
this pull request
Feb 15, 2024
* client/web: add metric for exit node advertising Updates tailscale/corp#15215 Signed-off-by: Naman Sood <mail@nsood.in> * client/web: use http request's context for IncrementCounter Updates #cleanup Signed-off-by: Naman Sood <mail@nsood.in> --------- Signed-off-by: Naman Sood <mail@nsood.in> Signed-off-by: Alex Paguis <alex@windscribe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates https://github.com/tailscale/corp/issues/15215.