cmd/k8s-operator: explicitly set tcp on VIPService port configuration for Ingress with ProxyGroup #16199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Revisions
☑️ AI review skipped for r2 HelpReact with emojis to give feedback on AI-generated reviews:
We'd love to hear from you—reach out anytime at team@review.ai. |
… for Ingress with ProxyGroup Updates tailscale/corp#24795 Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
ChaosInTheCRD
force-pushed
the
chaosinthecrd/k8s-operator-tailscale-service-ports
branch
from
2370214 to
3fc6bcb
Compare
|
Still needs manual testing |
sailorfrag
approved these changes
Jun 5, 2025
irbekrm
reviewed
Jun 8, 2025
|
This seems to be working well for both Ingress and Services HA 😄 |
ChaosInTheCRD
deleted the
chaosinthecrd/k8s-operator-tailscale-service-ports
branch
ChaosInTheCRD
added a commit
that referenced
this pull request
Jun 9, 2025
… for Ingress with ProxyGroup (#16199) Updates tailscale/corp#24795 Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
ChaosInTheCRD
added a commit
that referenced
this pull request
Jun 9, 2025
… for Ingress with ProxyGroup (#16199) Updates tailscale/corp#24795 Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk> (cherry picked from commit 4456f77)
ChaosInTheCRD
added a commit
that referenced
this pull request
Jun 9, 2025
… for Ingress with ProxyGroup (#16199) (#16226) Updates tailscale/corp#24795 (cherry picked from commit 4456f77) Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
ChaosInTheCRD
restored the
chaosinthecrd/k8s-operator-tailscale-service-ports
branch
thirdeyenick
pushed a commit
to ninech/tailscale
that referenced
this pull request
Jul 2, 2025
… for Ingress with ProxyGroup (tailscale#16199) (tailscale#16226) Updates tailscale/corp#24795 (cherry picked from commit 4456f77) Signed-off-by: chaosinthecrd <tom@tmlabs.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates https://github.com/tailscale/corp/issues/24795