tailscale.nuspec, tools: remove vestigial content and modernize packa… #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge scripts Much of the content in our package scripts was for dealing with NSIS and our own WinTun, neither of which exist anymore in modern versions of Tailscale. We make a few minor updates to tailscale.nuspec to keep its contents up to date. We remove tailscale.cer and the certificate installation script, as those are no longer necessary. We remove the uninstall script, as we may simply rely on Chocolatey's AutoUninstall functionality (which groks MSI). We update the beforemodify script to remove any previously installed certificate. We remove the old bits that would explicitly stop tailscaled, as this is always done in the MSI. Tested install, uninstall, upgrade from MSI, upgrade from NSIS (1.34.0). Fixes tailscale/tailscale#10839 Signed-off-by: Aaron Klotz <aaron@tailscale.com>
nickkhyl
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ge scripts
Much of the content in our package scripts was for dealing with NSIS and our own WinTun, neither of which exist anymore in modern versions of Tailscale.
We make a few minor updates to tailscale.nuspec to keep its contents up to date.
We remove tailscale.cer and the certificate installation script, as those are no longer necessary.
We remove the uninstall script, as we may simply rely on Chocolatey's AutoUninstall functionality (which groks MSI).
We update the beforemodify script to remove any previously installed certificate. We remove the old bits that would explicitly stop tailscaled, as this is always done in the MSI.
Tested install, uninstall, upgrade from MSI, upgrade from NSIS (1.34.0).
Fixes tailscale/tailscale#10839