path{.go,._test.go}: catch staticcheck.conf lookups above @ #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staticcheck currently walks the module path to look for staticcheck.conf files and don't stop at @. If lookups succeed it attempts to parse the returned as staticcheck.conf file even if it's a directory, such as in our case, where we assume that any lookups for paths without '@' are in-process building of module path. This change just special cases staticcheck.conf and ensures that any lookups for paths that end in staticcheck.conf and don't contain '@' return ErrIsNotExists. Updates #17 Signed-off-by: Irbe Krumina <irbekrm@gmail.com>
bradfitz
approved these changes
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special case lookups for path that end with
staticcheck.conf- assume that this is staticcheck looking for its configfiles above@rather than a legitimate module path being built and return 'not exists' to avoid staticcheck failing when attempting to parse the returned as its configfile.Updates #17