"go mod verify" failure on Windows with NFS

[bradfitz]

when using gomodfs over NFS from Windows, I saw:

C:\Users\bradfitz\src\tailscale>go mod verify
github.com/bramvdbogaerde/go-scp v1.4.0: dir has been modified (Z:\github.com\bramvdbogaerde\go-scp@v1.4.0)

We should add that to the CI test & see what's happening there.

[bradfitz]

On a real disk, that repo has an "exotic file" ... tests/data/Exöt1ç download file.txt.txt

And it's in their zip:

% cd $(go env GOMODCACHE)
% find . | grep go-scp | grep -E '/Ex|zip$'
./cache/download/github.com/bramvdbogaerde/go-scp/@v/v1.5.0.zip
./cache/download/github.com/bramvdbogaerde/go-scp/@v/v1.4.0.zip
./github.com/bramvdbogaerde/go-scp@v1.4.0/tests/data/Exöt1ç download file.txt.txt
./github.com/bramvdbogaerde/go-scp@v1.5.0/tests/data/Exöt1ç download file.txt.txt

% unzip -l ./cache/download/github.com/bramvdbogaerde/go-scp/@v/v1.5.0.zip | grep Ex
       23  00-00-1980 00:00   github.com/bramvdbogaerde/go-scp@v1.5.0/tests/data/Ex+�t1+� download file.txt.txt
% unzip -l ./cache/download/github.com/bramvdbogaerde/go-scp/@v/v1.4.0.zip | grep Ex
       23  00-00-1980 00:00   github.com/bramvdbogaerde/go-scp@v1.4.0/tests/data/Ex+�t1+� download file.txt.txt

But on gomodfs it's missing:

% ls -l '/mnt/gomodfs/github.com/bramvdbogaerde/go-scp@v1.4.0/tests/data/'
total 2
-rw-r--r--  1 root  wheel  50 Nov 12  2009 another_file.txt
-rw-r--r--  1 root  wheel   9 Nov 12  2009 upload_file.txt
 ls -l '/mnt/gomodfs/github.com/bramvdbogaerde/go-scp@v1.5.0/tests/data/'
total 2
-rw-r--r--  1 root  wheel  50 Nov 12  2009 another_file.txt
-rw-r--r--  1 root  wheel   9 Nov 12  2009 upload_file.txt

[bradfitz]

Ah, the problem is in the gitstore implementation it seems. This is what's making it to disk:

bradfitz@bradm4-4 001 % git show-ref
b9d16c8b2a74061c6afffbea724cf024668a9c7c refs/gomod/github.com%2Fbramvdbogaerde%2Fgo-scp@v1.4.0
bradfitz@bradm4-4 001 % git cat-file -p b9d16c8b2a74061c6afffbea724cf024668a9c7c
100644 blob 53c2712663850a919af224ef22ea5f3a96dc6cb2    info
100644 blob 31512e581f0fb265d6157df97091a94f0c12ad49    mod
040000 tree 603f4f68a3e8bbab5432f7096e7ac090ad76a4db    zip
100644 blob b1a2b42bcf81536cf955be667143bb7c715bd2a5    ziphash
bradfitz@bradm4-4 001 % git cat-file -p b9d16c8b2a74061c6afffbea724cf024668a9c7c:zip
040000 tree 77854d195f56dce0a61c0ea44b4aba03b0bbf98f    .github
100644 blob ab27d1e8232b5529e0ea805402c7d8af59b684da    .gitignore
100644 blob 14e2f777f6c395e7e04ab4aa306bbcc4b0c1120e    LICENSE.txt
100644 blob e37a76c188a70c11629ae2223e7b5a3216688c86    README.md
040000 tree 5cd2c57cd5633e8db9058d3bf03bda08b0fc60e6    auth
100644 blob ee7d6f808a1ae3c5cd861dac744c38481fbc9f18    client.go
100644 blob 3f1c16e41b8dc492b4fb337bb4e1f1b3169e61bb    configurer.go
100644 blob 31512e581f0fb265d6157df97091a94f0c12ad49    go.mod
100644 blob 49a98f6c6e4692ec322b17da1ace60163b856be3    go.sum
100644 blob ca19d719b0836dee84d9f7a30874b938b9099495    protocol.go
100644 blob 837ccaa8f1f4134d0f13e7353edbd7539a44fe28    scp.go
040000 tree 1933dfe8c655cef57cdf1e9cf69e30182e6d9e87    tests
100644 blob 447775f12e6f56ebc3314fdeb4ab9696e8c2064b    utils.go
bradfitz@bradm4-4 001 % git cat-file -p b9d16c8b2a74061c6afffbea724cf024668a9c7c:zip/tests
100644 blob 20f1540aae189da16e8c0030404dc2e9471c782a    basic_test.go
040000 tree 1c484858d3da753cc09b47877a27c37379a14037    data
040000 tree c74ca2bf2948f2d45c478f480b0b68eb4fbe5a5c    entrypoint.d
100644 blob e08f34ba8b2f723a62408963df2c96fa89609eca    run_all.sh
040000 tree d564d0bc3dd917926892c55e3706cc116d5b165e    tmp
bradfitz@bradm4-4 001 % git cat-file -p b9d16c8b2a74061c6afffbea724cf024668a9c7c:zip/tests/data
100644 blob 7f191e8b5559b54db1218f0a7e08b1e99eb10523    "Ex\303\266t1\303\247 download file.txt.txt"
100644 blob 87b37c037cc6f1079ab3fb01517d55f7a08a43d4    another_file.txt
100644 blob 2bfa72238077394bd5d55d340f78e7e5d162437e    upload_file.txt

[bradfitz]

Yeah, we don't implement this unquoting:

% git "ls-tree" "-t" "-r" "--format=%(objectname) %(objectmode) %(objectsize) %(path)"  b9d16c8b2a74061c6afffbea724cf024668a9c7c
53c2712663850a919af224ef22ea5f3a96dc6cb2 100644 197 info
31512e581f0fb265d6157df97091a94f0c12ad49 100644 132 mod
603f4f68a3e8bbab5432f7096e7ac090ad76a4db 040000 - zip
77854d195f56dce0a61c0ea44b4aba03b0bbf98f 040000 - zip/.github
23b5046730acf429bbb1e7fc899cb8acd7441457 040000 - zip/.github/workflows
0096e56c429350830a7996dd730537bb711ca7c5 100644 356 zip/.github/workflows/ci.yml
ab27d1e8232b5529e0ea805402c7d8af59b684da 100644 14 zip/.gitignore
14e2f777f6c395e7e04ab4aa306bbcc4b0c1120e 100644 16726 zip/LICENSE.txt
e37a76c188a70c11629ae2223e7b5a3216688c86 100644 2974 zip/README.md
5cd2c57cd5633e8db9058d3bf03bda08b0fc60e6 040000 - zip/auth
a93d0683058565725a83441b34ff9c35250cea8f 100644 2376 zip/auth/key.go
ee7d6f808a1ae3c5cd861dac744c38481fbc9f18 100644 9557 zip/client.go
3f1c16e41b8dc492b4fb337bb4e1f1b3169e61bb 100644 2257 zip/configurer.go
31512e581f0fb265d6157df97091a94f0c12ad49 100644 132 zip/go.mod
49a98f6c6e4692ec322b17da1ace60163b856be3 100644 467 zip/go.sum
ca19d719b0836dee84d9f7a30874b938b9099495 100644 3130 zip/protocol.go
837ccaa8f1f4134d0f13e7353edbd7539a44fe28 100644 1400 zip/scp.go
1933dfe8c655cef57cdf1e9cf69e30182e6d9e87 040000 - zip/tests
20f1540aae189da16e8c0030404dc2e9471c782a 100644 12209 zip/tests/basic_test.go
1c484858d3da753cc09b47877a27c37379a14037 040000 - zip/tests/data
7f191e8b5559b54db1218f0a7e08b1e99eb10523 100644 23 "zip/tests/data/Ex\303\266t1\303\247 download file.txt.txt"
87b37c037cc6f1079ab3fb01517d55f7a08a43d4 100644 50 zip/tests/data/another_file.txt
2bfa72238077394bd5d55d340f78e7e5d162437e 100644 9 zip/tests/data/upload_file.txt
c74ca2bf2948f2d45c478f480b0b68eb4fbe5a5c 040000 - zip/tests/entrypoint.d
dc6a15d629b31e5a4008055698f739cf6c0244da 100644 163 zip/tests/entrypoint.d/setpasswd.sh
e08f34ba8b2f723a62408963df2c96fa89609eca 100644 2024 zip/tests/run_all.sh
d564d0bc3dd917926892c55e3706cc116d5b165e 040000 - zip/tests/tmp
e69de29bb2d1d6434b8b29ae775ad8c2e48c5391 100644 0 zip/tests/tmp/.gitkeep
447775f12e6f56ebc3314fdeb4ab9696e8c2064b 100644 589 zip/utils.go
b1a2b42bcf81536cf955be667143bb7c715bd2a5 100644 47 ziphash