Skip to content

Commit

Permalink
acme/autocert: remove TestRenewFromCache skips
Browse files Browse the repository at this point in the history
Removes the skips from TestRenewFromCache and
TestRenewFromCacheAlreadyRenewed, which were added due to flakes which
may have been fixed by the renewal timer change.

Updates golang/go#51080

Change-Id: Ib953a24e610e89dfbbea450a4c257c105055ce7e
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/433815
Run-TryBot: Roland Shoemaker <roland@golang.org>
Auto-Submit: Roland Shoemaker <roland@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
  • Loading branch information
rolandshoemaker authored and gopherbot committed Sep 26, 2022
1 parent 4ba4fb4 commit eccd636
Showing 1 changed file with 0 additions and 19 deletions.
19 changes: 0 additions & 19 deletions acme/autocert/renewal_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"context"
"crypto"
"crypto/ecdsa"
"runtime"
"testing"
"time"

Expand Down Expand Up @@ -43,15 +42,6 @@ func TestRenewalNext(t *testing.T) {
}

func TestRenewFromCache(t *testing.T) {
if runtime.GOOS == "windows" && runtime.GOARCH == "arm64" {
// This test was observed to fail frequently in Dial with "connectex: No
// connection could be made because the target machine actively refused it."
//
// Failures started around CL 381715, so it looks to me (bcmills) like an
// undiagnosed bug in (or exposed by) acmetest.CAServer.
t.Skipf("skipping test on windows/arm64: see https://go.dev/issue/51080")
}

man := testManager(t)
man.RenewBefore = 24 * time.Hour

Expand Down Expand Up @@ -137,15 +127,6 @@ func TestRenewFromCache(t *testing.T) {
}

func TestRenewFromCacheAlreadyRenewed(t *testing.T) {
if runtime.GOOS == "windows" && runtime.GOARCH == "arm64" {
// This test was observed to fail frequently in Dial with "connectex: No
// connection could be made because the target machine actively refused it."
//
// Failures started around CL 381715, so it looks to me (bcmills) like an
// undiagnosed bug in (or exposed by) acmetest.CAServer.
t.Skipf("skipping test on windows/arm64: see https://go.dev/issue/51080")
}

ca := acmetest.NewCAServer(t).Start()
man := testManager(t)
man.RenewBefore = 24 * time.Hour
Expand Down

0 comments on commit eccd636

Please sign in to comment.