net/http: add Transport.RoundTrip enforcement hook #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maisem
approved these changes
Jul 23, 2023
| if f == nil { | ||
| panic("nil func") | ||
| } | ||
| if roundTripEnforcer != nil { |
There was a problem hiding this comment.
It's useful to be able to set this back to nil after a test runs. I've run into that issue for the other hooks that we have.
There was a problem hiding this comment.
It's meant to be installed exactly once in init. If we want per-test control, we provide that ourselves in our installed hook.
The other two hooks are like this too.
Updates #55 Updates tailscale/corp#12702 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
bradfitz
force-pushed
the
bradfitz/http_enforce
branch
from
aee11cc
to
1ecb1d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
net/http: add enforcement hook to Transport.RoundTrip, like our net ones
Updates #55
Updates https://github.com/tailscale/corp/issues/12702