Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

{action.yml,.github}: add support for macOS #161

Merged
merged 1 commit into from
Mar 13, 2025
Merged

{action.yml,.github}: add support for macOS #161

merged 1 commit into from
Mar 13, 2025

Conversation

mpminardi
Copy link
Member

Add support for running the action on macOS-based GitHub runners.

Updates #157

@mpminardi @gurchik
{action.yml,.github}: add support for macOS
f0c3dac 
Add support for running the action on macOS-based GitHub runners.

Updates #157

Co-authored-by: Derek Gurchik <602444+gurchik@users.noreply.github.com>
@mpminardi mpminardi self-assigned this Mar 5, 2025
@mpminardi mpminardi marked this pull request as ready for review March 5, 2025 19:40
@mpminardi mpminardi requested review from oxtoacart and barnstar March 5, 2025 19:40
barnstar
barnstar approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@barnstar barnstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all of our CI workflows will pass on mac runners ATM... But we can cross that bridge when we get to it.

Base automatically changed from mpminardi/windows-support to main March 13, 2025 21:31
@mpminardi mpminardi merged commit 93605f7 into main Mar 13, 2025
@mpminardi mpminardi deleted the mpminardi/mac-support branch March 13, 2025 22:00
@gurchik
Copy link
Contributor

gurchik commented Mar 14, 2025

Thanks @mpminardi I will close #142

I notice my PR had a networksetup -setdnsservers step and yours doesn't. Can you say more about that? The reason I ask is because since I've opened the PR I actually noticed this step does not always work the way I'd expect and I was wondering if you also had this problem and if you had any other thoughts about it.

@gurchik gurchik mentioned this pull request Mar 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barnstar barnstar barnstar approved these changes

@oxtoacart oxtoacart oxtoacart approved these changes

Assignees

@mpminardi mpminardi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mpminardi @gurchik @barnstar @oxtoacart