Update scripts to be compatible with sh
#22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had this same problem when running as a non-root user: @rhettg ➜ /workspaces/mcc (rhettg-configure-tailscale) $ /usr/local/sbin/tailscaled-entrypoint
++ id -u
+ [[ 1000 -eq 0 ]]
+ command -v sudo
+ exec
+ sudo --non-interactive sh -c 'mkdir -p /workspaces/.tailscale ; /usr/local/sbin/tailscaled \
--statedir=/workspaces/.tailscale/ \
--socket=/var/run/tailscale/tailscaled.sock \
--port=41641 >& /dev/null'
sh: 4: Syntax error: Bad fd number |
noncombatant
approved these changes
Jul 24, 2023
There was a problem hiding this comment.
The shebang line calls for bash, and IMO we should not support running bash scripts with other shells. (Who knows what else might break.)
That said, section 3.6.4 of bash's own docs (https://www.gnu.org/software/bash/manual/html_node/Redirections.html) says to prefer the POSIX syntax, so let's do that.
|
Can someone with write access merge this PR? |
|
@noncombatant (or other maintainer) Can you please cut a release for this? ❤️ |
|
Oops, sorry about that! Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage of
>&redirection operators in the install and entrypoint scripts causes the scripts to fail when run under the default shell, (when not bash). Usage of&>is preferred.