Fix clippy reported problems #49
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes occurrences flagged by the clippy lint
`single_char_pattern`. E.g.,
> warning: single-character string constant used as pattern
> --> src/print.rs:6:29
> |
> 6 | if self.0.ends_with("\n") {
> | ^^^^ help: try using a char instead: `'\n'`
> |
> = help: for further information visit
> https://rust-lang-nursery.github.io/rust-clippy/master/index.html#single_char_pattern
This change fixes occurrences flagged by the clippy lint `unused_io_amount`. E.g., > warning: handle written amount returned or use `Write::write_all` instead > --> src/help.rs:74:13 > | > 74 | try!(buf.write(word.as_bytes())); > | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > | > = note: #[warn(clippy::unused_io_amount)] on by default > = help: for further information visit > https://rust-lang-nursery.github.io/rust-clippy/master/index.html#unused_io_amount
This change fixes occurrences flagged by the clippy lint `len_zero`.
E.g.,
> warning: length comparison to one
> --> src/parser.rs:694:12
> |
> 694 | if names.len() < 1 {
> | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `names.is_empty()`
> |
> = help: for further information visit
> https://rust-lang-nursery.github.io/rust-clippy/master/index.html#len_zero
This change fixes occurrences flagged by the clippy lint
`write_with_newline`. E.g.,
> warning: using `write!()` with a format string that ends in a single
> newline, consider using `writeln!()` instead
> --> src/parser.rs:410:29
> |
> 410 | / write!(self.stderr,
> 411 | | "WARNING: Environment variable {}: {}\n",
> 412 | | evar.name, err).ok();
> | |_______________________________________________^
> |
> = note: #[warn(clippy::write_with_newline)] on by default
> = help: for further information visit
> https://rust-lang-nursery.github.io/rust-clippy/master/index.html#write_with_newline
This change fixes occurrences flagged by the clippy lint `double_parens`. E.g., > warning: Consider removing unnecessary double parentheses > --> src/help.rs:38:36 > | > 38 | Some((idx, ch)) => ((idx, ch)), > | ^^^^^^^^^^^ > | > = note: #[warn(clippy::double_parens)] on by default > = help: for further information visit > https://rust-lang-nursery.github.io/rust-clippy/master/index.html#double_parens
|
Looks god. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set fixes a couple of clippy reported problems that I noticed while integrating this package into one of my crates. While not all of them are serious, they should be pretty uncontroversial and at least the ignored write amount should definitely be fixed.