Skip to content

Batch integration #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Mar 6, 2023
Merged

Batch integration #32

merged 10 commits into from
Mar 6, 2023

Conversation

Alpha1337k
Copy link
Contributor

Hi there,

I created a class for batch operations. Includes all routes, and supports id's for delete / restore.

Also tried to make some tests, but not sure if the quality is upto spec.

Please let me know what you think + need for improvements.

Thanks,

@Alpha1337k
Copy link
Contributor Author

Hi @alexzarbn were you able to take a look?

@alexzarbn
Copy link
Member

Hello @Alpha1337k,

Thank you for the PR. Please update it in a way how operations are implemented in the /src/drivers/default/queryBuilder.ts, instead of introducing a dedicated class.

@Alpha1337k
Copy link
Contributor Author

Do you mean like Post.$query().batchStore([]) or like Post.$batch().store([])? I don't envision the first one well, since I think about Batch as an overlaying entity, and not as a "Post", or else. Also, both have the issue where they can be called on an existing variable: item.$query().batchStore([item1,item2 ...]) What to do in this case?

Let me know your thoughts.

@alexzarbn
Copy link
Member

Yes, I mean like Post.$query().batchStore([]) - it follows the current structure of other operations.

@Alpha1337k
Copy link
Contributor Author

@alexzarbn Should be better now. Take a look.

@alexzarbn
Copy link
Member

Awesome, thank you! Merging ~

@alexzarbn alexzarbn merged commit 331b151 into tailflow:main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants