-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add /showcase/graphql
endpoint
#1015
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1015 +/- ##
==========================================
+ Coverage 88.33% 88.38% +0.04%
==========================================
Files 102 103 +1
Lines 11034 11115 +81
==========================================
+ Hits 9747 9824 +77
- Misses 1287 1291 +4 ☔ View full report in Codecov by Sentry. |
WASM build fails should be fixed. Unfortunately I'm not sure why the linter failing. The action doesn't log any issues and rustfmt is broken for me locally so I can't check for it easily. Might spin up a codespace and try running it there. |
Ugh, nevermind, I'm running into compiler problems... |
@tusharmath Everything should be resolved now wrt CI checks. Also opened up a codespace to fix lint successfully, my local rustfmt seems to be messed up. What's the codecov success condition? |
/showcase/graphql
endpoint/showcase/graphql
endpoint
Rebased on main and changed the internal API a bit. AppContext not having type generics made it quite a bit prettier! |
Running into a JS-related |
Alright, this is should be passing everywhere now :) |
c7a8411
to
9f17884
Compare
This is ready now @tusharmath |
Summary:
This PR adds a
/showcase/graphql
endpoint that behaves like how it's described in #1012. Some caveats:Upstream
config will be ignored.This PR also rewrites
cloudflare/src/handler.rs
to use the new showcase logic. That implementation has none of the above caveats, and should continue to work like it has before, except that it may have even better error reporting.Issue Reference(s):
Fixes #1012
/claim #1012
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>