Allow specifying custom profiles #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afnanenayet
force-pushed
the
custom-profiles
branch
from
617225e
to
d2ef737
Compare
Allow for users to specify a specific profile.
afnanenayet
force-pushed
the
custom-profiles
branch
from
d2ef737
to
609508c
Compare
|
Thanks for the PR! The upload-rust-binary-action/main.sh Line 244 in 609508c upload-rust-binary-action/main.sh Lines 251 to 252 in 609508c upload-rust-binary-action/main.sh Line 263 in 609508c See this code in cargo-llvm-cov for the directory name used. |
The `release` profile was hardcoded and will fail if we change the profile.
|
Good catch, thanks |
taiki-e
reviewed
May 10, 2023
Set the default profile env var to "release" if it's not supplied.
Address feedback about handling special Cargo profiles.
taiki-e
reviewed
May 11, 2023
Use the profile name provided by the user, always. We separate out a new variable for the profile directory name for clarity, and so we use the correct profile as requested by the user.
taiki-e
reviewed
May 13, 2023
We were not supposed to change the name of the field we're pulling.
|
Published in 1.14.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for users to specify a specific profile. I have a ci-specific profile, so it would be useful to be able to set a different profile in the action config.