Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support for AVR and MSP430 custom targets #50

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Dec 14, 2022

  • Fix build error when not using portable_atomic_unsafe_assume_single_core cfg on AVR and MSP430 custom targets.

    Since 0.3.11, atomic CAS was supported without the cfg on AVR and MSP430 builtin targets, but that change was not applied to custom targets.

@taiki-e taiki-e added O-avr Target: AVR O-msp430 Target: MSP430 labels Dec 14, 2022
@taiki-e
Copy link
Owner Author

taiki-e commented Dec 14, 2022

bors r+

@taiki-e
Copy link
Owner Author

taiki-e commented Dec 14, 2022

FYI @notgull as you seem to have run into this issue.

Copy link
Contributor

@notgull notgull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bors
Copy link
Contributor

bors bot commented Dec 15, 2022

@bors bors bot merged commit f72020e into main Dec 15, 2022
@bors bors bot deleted the custom-target branch December 15, 2022 00:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-avr Target: AVR O-msp430 Target: MSP430
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants