-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an option to merge coverage of generics in the summary #43
Labels
C-enhancement
Category: A new feature or an improvement for an existing one
help wanted
Call for participation: Help is requested to fix this issue
Comments
This seems reasonable to me.
|
taiki-e
added
the
C-enhancement
Category: A new feature or an improvement for an existing one
label
Aug 7, 2021
Hmm, I'm not sure how this can be implemented on our side because the |
taiki-e
added
the
help wanted
Call for participation: Help is requested to fix this issue
label
Aug 7, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-enhancement
Category: A new feature or an improvement for an existing one
help wanted
Call for participation: Help is requested to fix this issue
First, thanks for a very useful tool!
It would be nice if there was an command line option to merge the coverage of different instantiations of generic functions in the summary of the coverge of a file, so that it would show 100% coverage if the tests covered all of a generic function, even if different regions of the function were covered by different instantiations. Consider the following source file:
With cargo-llvm-cov 0.1.0-alpha.4, the report will show a region coverage of 88.89% (8/9), even though all regions of the generic function are marked as covered. The current rule seems to be that there needs to be at least one instantiation with 100% coverage for the generic function to be counted as 100% covered. This is probably a good choice for some situations, but sometimes you have a generic function that is difficult to cover completely with a single instantiation and for those cases it would be nice to have an option to merge the coverage of all instantiations when computing the summary.
The text was updated successfully, but these errors were encountered: