Fix/century pump setdrivestate error - #1169
Merged
tagyoureit merged 1 commit intoApr 10, 2026
Merged
Conversation
…validation, and fault response - Enhanced header validation to only accept messages from known RegalModbus pumps - Improve collision detection by verifying pump address against configured devices - Add special handling for NACK responses on Go/Stop commands (0x41, 0x42) - When pump returns NACK to control commands, set driveState and command to fault state (4) - Log pump faults with descriptive error messages instead of silent retries - Optimize Go/Stop command parameters: disable retries and response flag for fault scenarios - Add documentation for Go command behavior and NACK handling expectations
celestinjr
force-pushed
the
fix/century-pump-setdrivestate-error
branch
from
April 10, 2026 14:03
05ada91 to
582c934
Compare
celestinjr
marked this pull request as ready for review
April 10, 2026 14:16
tagyoureit
pushed a commit
that referenced
this pull request
Apr 10, 2026
…ents
- testRegalModbusHeader: resolve configured pump via getValue('regalmodbus') and sys.pumps.find
- RegalModbusStateMessage / setDriveStateAsync: merge PR #1169 with review follow-up
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving the reliability and accuracy of RegalModbus pump communication in the Nixie controller system. The main changes ensure that only messages from known, configured RegalModbus pumps are accepted, and they refine how drive state commands are sent to these pumps.
Inbound message filtering improvements:
testRegalModbusHeadermethod inMessages.tsto only accept messages from RegalModbus pumps that are explicitly configured in the system, preventing misidentification of noise or broadcast fragments.Pump command handling adjustments:
NixiePumpRegalModbus.setDriveStateAsyncabout the behavior of the Go command and its requirements for the motor state and error handling.setDriveStateAsyncto use zero retries and not expect a response, likely to avoid unnecessary command retries or waiting for responses that may not be sent in certain pump states.