log proper method #512
Merged
log proper method #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyandrews
force-pushed
the
log-proper-method
branch
from
6046dd1 to
6122ecb
Compare
jeremyandrews
commented
Aug 18, 2022
| @@ -1245,6 +1245,7 @@ impl GooseUser { | |||
| // POST request. | |||
| let goose_request = GooseRequest::builder() | |||
| .method(GooseMethod::Post) | |||
| .path(path) | |||
There was a problem hiding this comment.
We have to call .path(path) for consistent naming in the metrics, for this to work the same if you're using the builder directly.
|
Looks good to me. |
slashrsm
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
methodfunction to log proper method, closes HTML report doesn't include correct method and path when creating request using builder #511GooseRequest::builder()is used