More strict deserialization into primitives #661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New tests will be added in the following commit (review with "ignore whitespace changes mode" on)
failures (72):
trivial::cdata::char_::field
trivial::cdata::char_::primitive
trivial::cdata::f32_::field
trivial::cdata::f32_::primitive
trivial::cdata::f64_::field
trivial::cdata::f64_::primitive
trivial::cdata::false_::field
trivial::cdata::false_::primitive
trivial::cdata::i128_::field
trivial::cdata::i128_::primitive
trivial::cdata::i16_::field
trivial::cdata::i16_::primitive
trivial::cdata::i32_::field
trivial::cdata::i32_::primitive
trivial::cdata::i64_::field
trivial::cdata::i64_::primitive
trivial::cdata::i8_::field
trivial::cdata::i8_::primitive
trivial::cdata::isize_::field
trivial::cdata::isize_::primitive
trivial::cdata::string::field
trivial::cdata::string::primitive
trivial::cdata::true_::field
trivial::cdata::true_::primitive
trivial::cdata::u128_::field
trivial::cdata::u128_::primitive
trivial::cdata::u16_::field
trivial::cdata::u16_::primitive
trivial::cdata::u32_::field
trivial::cdata::u32_::primitive
trivial::cdata::u64_::field
trivial::cdata::u64_::primitive
trivial::cdata::u8_::field
trivial::cdata::u8_::primitive
trivial::cdata::usize_::field
trivial::cdata::usize_::primitive
trivial::text::char_::field
trivial::text::char_::primitive
trivial::text::f32_::field
trivial::text::f32_::primitive
trivial::text::f64_::field
trivial::text::f64_::primitive
trivial::text::false_::field
trivial::text::false_::primitive
trivial::text::i128_::field
trivial::text::i128_::primitive
trivial::text::i16_::field
trivial::text::i16_::primitive
trivial::text::i32_::field
trivial::text::i32_::primitive
trivial::text::i64_::field
trivial::text::i64_::primitive
trivial::text::i8_::field
trivial::text::i8_::primitive
trivial::text::isize_::field
trivial::text::isize_::primitive
trivial::text::string::field
trivial::text::string::primitive
trivial::text::true_::field
trivial::text::true_::primitive
trivial::text::u128_::field
trivial::text::u128_::primitive
trivial::text::u16_::field
trivial::text::u16_::primitive
trivial::text::u32_::field
trivial::text::u32_::primitive
trivial::text::u64_::field
trivial::text::u64_::primitive
trivial::text::u8_::field
trivial::text::u8_::primitive
trivial::text::usize_::field
trivial::text::usize_::primitive
… return error instead of returning `text`
when deserialize into primitive types (ex. `u32`, but not struct S { #[serde(rename = "$text")] field: u32 })
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #661 +/- ##
=======================================
Coverage 64.60% 64.61%
=======================================
Files 36 36
Lines 17290 17294 +4
=======================================
+ Hits 11170 11174 +4
Misses 6120 6120
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restricts ability to deserialize primitive types (numbers, booleans, characters, strings) from XML documents that contains a trailing tag after a text. Previously the error emitted only when tag was before text.
Before that PR the XML
can be successfully deserialized into
which is not that you want generally. Now the
DeError::UnexpectedStarterror is returned. Also, probably we want that42<something-wrong/>was passed to theu32::deserializeand deserialization fail because type decide that (for example, we might want to capture tag inString), but this would be possible only when #257 would be implemented.