Skip to content

Document some internal macros and other small improvements #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 12, 2023

Conversation

Mingun
Copy link
Collaborator

@Mingun Mingun commented Mar 11, 2023

  1. First, fixed all references to the XML standard to point to the version 1.1 of the standard.
  2. Second, document internal macros that performs reading.
  3. The last, add a quick reference to the deserializer module from the introduction page. I noticed, I often need it.

@Mingun Mingun added the documentation Issues about improvements or bugs in documentation label Mar 11, 2023
@Mingun Mingun requested a review from dralley March 11, 2023 19:35
@Mingun Mingun mentioned this pull request Mar 11, 2023
13 tasks
@codecov-commenter
Copy link

Codecov Report

Merging #577 (0c394c6) into master (f822669) will increase coverage by 0.03%.
The diff coverage is 95.65%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #577      +/-   ##
==========================================
+ Coverage   64.24%   64.27%   +0.03%     
==========================================
  Files          34       34              
  Lines       16618    16624       +6     
==========================================
+ Hits        10676    10685       +9     
+ Misses       5942     5939       -3     
Flag Coverage Δ
unittests 64.27% <95.65%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/de/key.rs 93.83% <ø> (ø)
src/de/simple_type.rs 93.86% <ø> (ø)
src/errors.rs 11.11% <ø> (ø)
src/name.rs 87.82% <ø> (ø)
src/reader/mod.rs 94.93% <ø> (ø)
src/reader/slice_reader.rs 100.00% <ø> (ø)
src/se/key.rs 96.79% <ø> (ø)
src/se/mod.rs 92.11% <ø> (ø)
src/lib.rs 20.17% <80.00%> (+0.06%) ⬆️
src/de/mod.rs 69.67% <100.00%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dralley dralley merged commit 1a967a6 into tafia:master Mar 12, 2023
@Mingun Mingun deleted the doc branch March 17, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues about improvements or bugs in documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants