-
Notifications
You must be signed in to change notification settings - Fork 252
Experimental: add dom wrapper #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do you plan on merging this anytime soon? |
I don't know. I do not really need it at the moment and I haven't been asked it. It was more a proof of concept. |
I'm interested, but wouldn' it be better to create a separate crate for this (probably also the reason you don't merge it into quick-xml now)? Thus also a separate git repo in this same project. |
Yes it would definitely be better on another crate. Eventually I'd love having a crate just to declare the traits to have a DOM and several implementation (including one for quick-xml, xml-rs, xml5ever, RustyXML etc ...). I am still struggling to find some time but if anyone wants to starts I'll be happy to help! |
I try to use your dom, after some hacking (like escape module is private), I now get stuck at:
|
Sorry I haven't answered that! |
I am closing this for now as minidom crate has apparently switched to using quick-xml. Let me know if you think otherwise. |
This pull request strictly improves the current situation (shouldn't be a breaking change). Fixes situation like #56 (comment)
I updated this code to work with the current quick-xml here. |
This PR adds a very basic DOM like wrapper on top of quick-xml pull based reader.
The typical usage is: