Support xlsx sheet sizes beyond u32::MAX #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves tafia#174 This PR includes the failing file from tafia#174. It appears the issue was that the sheet was the max size but filled with empty cells. However, the length checking code only supported lengths up to u32::MAX. This change means that xlsx files with more than the maximum number of rows or columns allowed by the xlsx standard. I feel like this should not cause a hard fail as other tools that produce xlsx files do not always respect these limits. To give the user some kind of indication of the issue I have added a couple of warning log messages.
|
This is great, thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #174
This PR includes the failing file from #174. It appears the issue was
that the sheet was the max size but filled with empty cells. However,
the length checking code only supported lengths up to u32::MAX.
This change means that xlsx files with more than the maximum number of
rows or columns allowed by the xlsx standard. I feel like this should
not cause a hard fail as other tools that produce xlsx files do not
always respect these limits. To give the user some kind of indication of
the issue I have added a couple of warning log messages.