Skip to content

fix(server): pass MCP description via instructions, not version #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
syf2211 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(server): pass MCP description via instructions, not version #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion fastapi_mcp/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,11 @@ def setup_server(self) -> None:
# Filter tools based on operation IDs and tags
self.tools = self._filter_tools(all_tools, openapi_schema)

mcp_server: Server = Server(self.name, self.description)
mcp_server: Server = Server(
self.name,
version=self.fastapi.version,
instructions=self.description,
)

@mcp_server.list_tools()
async def handle_list_tools() -> List[types.Tool]:
Expand Down
4 changes: 4 additions & 0 deletions tests/test_basic_functionality.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,10 @@ def test_create_mcp_server(simple_fastapi_app: FastAPI):
assert len(mcp.tools) > 0, "Should have extracted tools from the app"
assert len(mcp.operation_map) > 0, "Should have operation mapping"

assert mcp.server.version == simple_fastapi_app.version
assert mcp.server.instructions == "Test description"
assert mcp.server.version != mcp.server.instructions

# Check that the operation map contains all expected operations from simple_app
expected_operations = ["list_items", "get_item", "create_item", "update_item", "delete_item", "raise_error"]
for op in expected_operations:
Expand Down