Run deployment descriptors in correct order. #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously determined the order of multiple deployment descriptors in a single jar according to the order of those entries as stored in the jar (used in that order for install, and that order reversed for remove). But that wasn't correct. I got my hands on 2003 and 2006 drafts of the SQL/JRT spec and they both clearly say it is the order _as the entries are listed in the manifest_ that matters (again, in that order for install, and the reverse for remove). This should be a welcome improvement, because I had noted back in commit 0edc9e5 that maven doesn't always put things in a jar in the same order, and that was causing the pljava-examples jar to be broken about half the time (for autodeployment anyway). But the manifest is a static file listing the ddrs in the right order, so as long as maven doesn't reorder it while putting it in the jar, that behavior should now be stable.
thallgren
added a commit
that referenced
this pull request
Jul 15, 2015
Run deployment descriptors in correct order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously determined the order of multiple deployment descriptors in
a single jar according to the order of those entries as stored in the jar
(used in that order for install, and that order reversed for remove).
But that wasn't correct. I got my hands on 2003 and 2006 drafts of the
SQL/JRT spec and they both clearly say it is the order as the entries
are listed in the manifest that matters (again, in that order for install,
and the reverse for remove).
This should be a welcome improvement, because I had noted back in
commit 0edc9e5 that maven doesn't always put things in a jar in
the same order, and that was causing the pljava-examples jar to be
broken about half the time (for autodeployment anyway). But the manifest
is a static file listing the ddrs in the right order, so as long as
maven doesn't reorder it while putting it in the jar, that behavior
should now be stable.
Now there still seems to be a lingering problem (for me anyway) where
unexpected class not found errors appear during autodeployment, suggesting
maybe
assertInPathisn't doing something right, but that's a question foranother day.