Skip to content

fix: union with parsedModules #2311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Mar 31, 2025
Merged

Conversation

jeshecdom
Copy link
Contributor

@jeshecdom jeshecdom commented Mar 6, 2025

Issue

Closes #2310.
Closes #2429.

To run autogeneration of makeX functions, execute:
yarn gen:make-funs
It will create the file src/ast/generated/make-factory.ts.

Checklist

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases

@jeshecdom jeshecdom marked this pull request as ready for review March 6, 2025 13:05
@jeshecdom jeshecdom requested a review from a team as a code owner March 6, 2025 13:05
Copy link
Contributor

@verytactical verytactical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^

@verytactical verytactical changed the title fix: Union with parsedModules fix: union with parsedModules Mar 12, 2025
verytactical
verytactical previously approved these changes Mar 24, 2025
@anton-trunov anton-trunov added this to the v1.6.6 milestone Mar 31, 2025
@anton-trunov anton-trunov merged commit 9795bb4 into main Mar 31, 2025
25 checks passed
@anton-trunov anton-trunov deleted the jeshecdom/parsed-modules-union branch March 31, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants