Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #7 issue #8

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Fixed #7 issue #8

merged 5 commits into from
Dec 10, 2024

Conversation

Shvandre
Copy link
Contributor

@Shvandre Shvandre commented Dec 5, 2024

Closes #7

Typo, but may be a security breach. (Though those messages should never be bounced, but maybe it is possible to make them bounce back)

Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add regression tests

@Shvandre Shvandre requested a review from anton-trunov December 5, 2024 20:55
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please open an issue about un-testability of the fix we discussed elsewhere

@Shvandre
Copy link
Contributor Author

Opened an issue and mentioned it in the code comment. @anton-trunov Can you, please, review this, so I will rebase GasTests on new main?

@anton-trunov anton-trunov merged commit fcc2411 into main Dec 10, 2024
1 check passed
@anton-trunov anton-trunov deleted the 7 branch December 10, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible bug in bounced<TokenTransferInternal> receiver
2 participants