[bugfix] quick fix of wait#82
Merged
peaceforeverCN merged 5 commits intotaco-project:mainfrom Dec 15, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the transfer operation completion tracking system by replacing tuple-based (graph_id, op_id) pairs with a structured CompletedOp dataclass throughout the codebase. This change improves type safety and code clarity while fixing inconsistencies in how completed operations are represented across different components.
Key Changes:
- Introduced a new
CompletedOpdataclass to encapsulate graph_id and op_id pairs with helper methods - Updated all return types from
List[Tuple[int, int]]toList[CompletedOp]across the transfer manager interfaces - Refactored completion handling logic to use
CompletedOpmethods likeis_graph_completed()instead of checkingop_id == -1
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| flexkv/common/transfer.py | Added CompletedOp dataclass with helper methods for graph completion checks and tuple conversion |
| flexkv/transfer/transfer_engine.py | Updated completion queue to use CompletedOp objects and modified method signatures to return List[CompletedOp] |
| flexkv/transfer_manager.py | Refactored all transfer manager classes to use CompletedOp instead of tuples, updated completion handling logic |
| flexkv/kvtask.py | Updated task completion tracking to work with CompletedOp objects using their accessor methods |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Luis-xu
pushed a commit
to peaceforeverCN/FlexKV
that referenced
this pull request
Dec 26, 2025
* update benchmark worker * status map * enable nvtx * fix default config * clear cpu to test ssd cache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix inconsistence of (graph_id, op_id) pair with those in transfer engine here
FlexKV/flexkv/transfer/transfer_engine.py
Line 328 in 078f4a9