[bugfix] fix incorrect num_tokens_to_get/put#4
Merged
peaceforeverCN merged 1 commit intotaco-project:devfrom Sep 8, 2025
Merged
[bugfix] fix incorrect num_tokens_to_get/put#4peaceforeverCN merged 1 commit intotaco-project:devfrom
peaceforeverCN merged 1 commit intotaco-project:devfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the calculation of num_tokens_to_get and num_tokens_to_put in the VLLM v1 adapter. The fix ensures proper block size alignment by adding 1 to the token count before applying the ceiling division operation.
- Corrects block size calculation logic in
_get_matchmethod - Corrects block size calculation logic in
_put_matchmethod
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
linhu-nv
approved these changes
Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.