Skip to content

Comments

add bypass cpu capability for local transfer#104

Open
didoteebin wants to merge 2 commits intotaco-project:mainfrom
didoteebin:main
Open

add bypass cpu capability for local transfer#104
didoteebin wants to merge 2 commits intotaco-project:mainfrom
didoteebin:main

Conversation

@didoteebin
Copy link

Add bypass cpu capability for local transfer . Log as below:

[FLEXKV] INFO 02-06 03:06:26.516 [worker.py:218] D2DISK transfer request: 33882 finished transfer data size: 0.017578125 GB transfer time: 0.0102 s transfer bandwidth: 1.85 GB/s
[FLEXKV] INFO 02-06 03:06:27.187 [worker.py:218] DISK2D transfer request: 34006 finished transfer data size: 2.759765625 GB transfer time: 0.6713 s transfer bandwidth: 4.41 GB/s

if len(allocated_cpu_blocks) < allocated_cpu_block_num:
self.cpu_cache_engine.recycle(allocated_cpu_blocks)
return self._empty_get_return(request_id)
if not enable_bypass_cpu:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是不是不应该加这个判断?因为本地cpu还会作为比如远程cpu到本地的中转。这种情况下即使是G3.5 bypass_cpu,其他介质不一定能够bypass_cpu的。从系统的角度来看,这个bypass_cpu应该是跟介质绑定的。应该有g3.5_bypass_cpu, gds_bypass_cpu, remote_memory_bypass_cpu?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants