Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Fix redirects #573

Merged
merged 6 commits into from
Mar 18, 2021
Merged

Fix redirects #573

merged 6 commits into from
Mar 18, 2021

Conversation

Soitora
Copy link
Member

@Soitora Soitora commented Mar 12, 2021

Maybe fix redirects?

@netlify
Copy link

netlify bot commented Mar 12, 2021 •
edited
Loading

Deploy preview for tachiyomi ready!

Built with commit 4c1515b

https://deploy-preview-573--tachiyomi.netlify.app

@Soitora
Copy link
Member Author

Soitora commented Mar 12, 2021

Hmm still redirects but gives 404 until page is refreshed, in local enviroment this works flawlessly. Maybe use Cloudflare for 301 for Permanent Redirects? Or anyone knows another solution to 301 redirecting?

@Soitora Soitora changed the title Fix redirects, maybe? (DRAFT, need to check Netlify PR preview) Fix redirects, maybe? (RFC) Mar 12, 2021
@Soitora Soitora marked this pull request as draft March 12, 2021 14:23
@arkon
Copy link
Contributor

arkon commented Mar 12, 2021

Can we not just update whatever old references there are and not have redirects?

@Soitora
Copy link
Member Author

Soitora commented Mar 12, 2021

Can we not just update whatever old references there are and not have redirects?

We can, but Google will whine on us but I guess that's fine

@Soitora Soitora added the Abandoned Abandoned Issue/PR label Mar 16, 2021
@Soitora Soitora changed the title Fix redirects, maybe? (RFC) Fix redirects (RFC) Mar 16, 2021
@Soitora Soitora closed this Mar 16, 2021
@Soitora Soitora reopened this Mar 16, 2021
@Soitora Soitora removed the Abandoned Abandoned Issue/PR label Mar 16, 2021
@Soitora Soitora changed the title Fix redirects (RFC) Fix redirects Mar 16, 2021
@Soitora Soitora marked this pull request as ready for review March 16, 2021 20:33
@Soitora
Copy link
Member Author

Soitora commented Mar 16, 2021 •
edited
Loading

Seems that doing a simple redirect then using dehydrate will fix the 404s

EDIT: Rebuilding package-lock didn't solve conflict, what's the best way to fix?

@Soitora Soitora requested a review from arkon March 18, 2021 00:46
@arkon
Copy link
Contributor

arkon commented Mar 18, 2021

Rebuilding package-lock didn't solve conflict, what's the best way to fix?

Did you rebase on top of master first?

@Soitora Soitora merged commit 18add6a into tachiyomiorg:master Mar 18, 2021
@Soitora Soitora deleted the redirectFix branch March 18, 2021 13:02
arkon pushed a commit that referenced this pull request Mar 18, 2021
@github-actions
Fix redirects (#573)
be81cc6 
* Fix redirects, maybe?

Maybe fix redirects?

* Change how pages are redirected

* Remove 'redirect-frontmatter' reference

* Try another method of making routes

* Try dehydration

* Update package-lock after rebase 18add6a
arkon pushed a commit that referenced this pull request Aug 10, 2021
@Soitora
Fix redirects (#573)
2255fd6 
* Fix redirects, maybe?

Maybe fix redirects?

* Change how pages are redirected

* Remove 'redirect-frontmatter' reference

* Try another method of making routes

* Try dehydration

* Update package-lock after rebase
arkon pushed a commit that referenced this pull request Aug 10, 2021
@github-actions
Fix redirects (#573)
dbde76b 
* Fix redirects, maybe?

Maybe fix redirects?

* Change how pages are redirected

* Remove 'redirect-frontmatter' reference

* Try another method of making routes

* Try dehydration

* Update package-lock after rebase 2255fd6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arkon arkon arkon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Soitora @arkon