TST: Build docs in CI #861
Open
+21
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Run mkdocs build --strict on PR's to main or pushes to main - Docs 'deploy' now depends on 'build' succeeding. - Bump actions/checkout - Pin Python version in Docs job to 3.12
DetachHead
reviewed
Nov 21, 2025
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: 3.x | ||
| python-version: '3.12' |
Collaborator
There was a problem hiding this comment.
to avoid duplicating the version number and make it easier to update in the future, can we make this a variable at the top of the file
DetachHead
reviewed
Nov 21, 2025
Collaborator
There was a problem hiding this comment.
this thread is just a reminder to myself to add this to the list of required checks in the repo settings before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #852
mkdocs build --stricton PR's to main or pushes to maindeploynow depends onbuildsucceeding.EDIT: Tested the new doc build job on my fork first, and its green!