remove ListConsumerGroupOffsetsOptions for backward compatibility on older connect versions #277
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannaTronsen
approved these changes
Jul 25, 2024
|
#273 is resolved by the reporter, but this PR still stands, at least for backward compatibilty cases |
rafamarquezv
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix to #273.
The connector uses transactional producers and I think this call is not needed, as stable offsets are available after producer commit. It is also breaking on earlier versions of connect.
I'm not certain if this is the proper fix, but appreciate if any maintaners of the repo/connector would take a look, so opening a PR to put things into motion 👍🏾 😄