Add right and bottom of area to JSON output#265
Merged
jazzido merged 1 commit intotabulapdf:masterfrom Dec 11, 2018
laigor:master
Merged
Add right and bottom of area to JSON output#265jazzido merged 1 commit intotabulapdf:masterfrom laigor:master
jazzido merged 1 commit intotabulapdf:masterfrom
laigor:master
Conversation
Contributor
|
Hi @laigor, Thanks for your contribution! I noticed that the tests for the JSON writer are failing after your commit. Would you mind updating this PR with the fixes? Thanks! |
Contributor
Author
|
I saw that the tests do not pass, but I do not know how to fix them. |
Member
|
I haven't checked, but if I recall correctly, the test is just checking that the output hasn't changed. Since this adds the |
jazzido
added a commit
that referenced
this pull request
Dec 11, 2018
Contributor
|
Tests modified, and PR merged. Thanks again @laigor ! |
EmpowerZ
pushed a commit
to EmpowerZ/tabula-java
that referenced
this pull request
Oct 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.