This repository has been archived by the owner on Jan 20, 2021. It is now read-only.
notes first page that has text elements in pages JSON #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable to me. |
jeremybmerrill
added a commit
that referenced
this pull request
Jan 25, 2015
notes first page that has text elements in pages JSON @jazzido: Let me know if you think this introduces a regression.
jeremybmerrill
added a commit
that referenced
this pull request
Jan 25, 2015
|
test added in a5ee307 |
jeremybmerrill
added a commit
that referenced
this pull request
Apr 25, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also remove texts key, since nothing used it and it was always empty
I'm PRing this in case there are unanticipated performance hits to using an object extractor in page metadata extraction (but only until we find a page with real text, then we stop.)