Skip to content

Downgrade Chakra to 1.x.x for React 17 compatibility #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Downgrade Chakra to 1.x.x for React 17 compatibility #203

wants to merge 1 commit into from

Conversation

craigmassie
Copy link

Chakra 2.x requires React 18, and unfortunately, isn't back-compatible. This repo doesn't seem to be making use of any Chakra 2.x specific features, but will crash due to some reference to useSyncExternalStore in Chakra.

I've tested the changes with a React 17 repo that I'm working on (upgrading to React 18 would be a huge undertaking for us), and everything seems to be running smoothly.

Happy to discuss here if this makes sense! If not, I'm happy to keep this in a fork.

@ciminelli
Copy link
Member

Thanks for the PR, @craigmassie!

We're going to do some research on this to see if there are any important changes for the components we're using, check for other compatibility issues, and think about future updates. We're also going to do some testing to see if everything looks/works as expected on Chakra v1 with React 18 and other versions. At first glance, I see we'll need to replace defineStyleConfig with extendTheme but will see what else there is, if anything. Will get back to you soon.

@ciminelli ciminelli requested review from civan and ciminelli January 17, 2024 22:03
@craigmassie
Copy link
Author

@ciminelli Really appreciate it, thank you so much!

@craigmassie
Copy link
Author

Not the primary issue with using csv-import-react, closing

@ciminelli
Copy link
Member

@craigmassie what was the primary issue you encountered?

@civan civan mentioned this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants