Conversation
|
@nnevalainen thanks for the reminder ping on this one. The changes look good to me; let me find one more pair of eyes to check. |
bcantoni
left a comment
bcantoni
left a comment
There was a problem hiding this comment.
Updating my review with just a couple minor changes needed.
| `consecutive_failed_count` | The number of failed consecutive executions. | ||
| `id` | The id of the task on the site. | ||
| `priority` | The priority of the task on the server. | ||
| `schedule_id` | The id of the schedule on the site. | ||
| `target` | An object, `datasource` or `workbook` which is associated to the task. Source file: models/target.py | ||
| `task_type` | Type of extract task - full or incremental refresh. |
There was a problem hiding this comment.
Suggest reordering these to be in the order shown in TaskItem class above, so id, task_type, ...).
|
|
||
| Name | Description | ||
| :--- | : --- | ||
| `req_option` | (Optional) You can pass the method a request object that contains additional parameters to filter the request. |
There was a problem hiding this comment.
This should be req_options plural to match
|
Thanks for the prompt reply. Are you @martinbpeters still planning to work on this? If not, how do we want to proceed? I, for one, can perform the required changes if allow edits from maintainers is checked and I'm granted the necessary permissions. |
- Some minor changes from my code review of #525 which added Tasks documentation - add Tasks to left-side nav
|
@nnevalainen FYI: to wrap this one up, I've merged @martinbpeters original PR and then in a separate commit added my suggested changes from the review. We should be all set here. |
3 participants
No description provided.