Skip to content

Add workbook and datasource name attributes to JobItem Model #1391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

ivanB1975
Copy link

Added the workbook_name to the attributes of the jobItem Model. Added also the test.

Copy link

salesforce-cla bot commented Jun 6, 2024

Thanks for the contribution! Unfortunately we can't verify the commit author(s): ivan.baldinotti@digitecgalaxus.ch <i***@.DG-CH-NBS-22242>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce Inc. Contributor License Agreement and this Pull Request will be revalidated.

@ivanB1975
Copy link
Author

ivanB1975 commented Jun 6, 2024

Cla is signed

grafik

@jorwoods
Copy link
Contributor

jorwoods commented Jun 7, 2024

@ivanB1975 I think if you're going to pull out workbook name, then you should pull out the datasource name as well.

@ivanB1975
Copy link
Author

@ivanB1975 I think if you're going to pull out workbook name, then you should pull out the datasource name as well.

Thanks for having a look at it. Ok, I will need to check this

@ivanB1975
Copy link
Author

@jorwoods I added the datasource name as well

@ivanB1975 ivanB1975 changed the title Add workbook name attribute to JobItem Model Add workbook and datasource name attributes to JobItem Model Jun 7, 2024
@bcantoni
Copy link
Contributor

I'll try close and reopen the PR to refresh the CLA bot status.

@bcantoni bcantoni closed this Jul 24, 2024
@bcantoni bcantoni reopened this Jul 24, 2024
@jacalata jacalata changed the base branch from master to development July 24, 2024 19:40
@jacalata jacalata merged commit 6885a8a into tableau:development Jul 29, 2024
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants