Skip to content

Add api annotation to all current endpoints#125

Merged
t8y8 merged 1 commit intotableau:developmentfrom
t8y8:55-f-annotate-apis
Jan 24, 2017
Merged

Add api annotation to all current endpoints#125
t8y8 merged 1 commit intotableau:developmentfrom
t8y8:55-f-annotate-apis

Conversation

@t8y8
Copy link
Collaborator

@t8y8 t8y8 commented Jan 7, 2017

Part two of addressing #55

Unittests pass and I manually tested against a live server for a simple case.

Supported versions were taken from our public documentation (and my memory) and I only had to make a few tests changes/tweaks -- though it turns out our default version was a float (2.3) and everywhere else we had a string "2.4" ... which made for the most cryptic error I've ever gotten in a unittest, but now that's fixed, and I made some tweaks to try and make error reporting better

Copy link
Contributor

@graysonarts graysonarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I generally prefer ' over " but I won't be a stickler. 🚀

@t8y8 t8y8 merged commit 2f66a6d into tableau:development Jan 24, 2017
@t8y8 t8y8 deleted the 55-f-annotate-apis branch January 24, 2017 15:10
graysonarts pushed a commit that referenced this pull request Mar 23, 2017
Part two of #125 

This backfills all existing APIs with their minimum version.
Checking this in early in release cycle for baketime.
graysonarts pushed a commit that referenced this pull request Mar 24, 2017
* Response to code reviews. Put all request options into 1 file. renamed sample to download_view_image.py. Comments clean up

* Add api annotation to all current endpoints (#125)

Part two of #125 

This backfills all existing APIs with their minimum version.
Checking this in early in release cycle for baketime.

* initial implement of get all and get specific for Extract Refresh Tasks

* fixing test failure in the schedule_item code

* pep8 fixes

* Download with extract_only and parameter checking (#143)

* Add a new decorator that checks parameters against the version. Used with the @api decorator.
* Add extract_only flags to workbooks and data sources, protected behind v2.5 flag

* Correct the path to extract refresh tasks

* fixing missed pep8 failure

* adding runNow to the interface

* fixing pep8 issues

* Add header documentation to the sample.

* addressing tyler's feedback
t8y8 added a commit to t8y8/server-client-python that referenced this pull request Jun 28, 2017
Part two of tableau#125 

This backfills all existing APIs with their minimum version.
Checking this in early in release cycle for baketime.
t8y8 pushed a commit to t8y8/server-client-python that referenced this pull request Jun 28, 2017
* Response to code reviews. Put all request options into 1 file. renamed sample to download_view_image.py. Comments clean up

* Add api annotation to all current endpoints (tableau#125)

Part two of tableau#125 

This backfills all existing APIs with their minimum version.
Checking this in early in release cycle for baketime.

* initial implement of get all and get specific for Extract Refresh Tasks

* fixing test failure in the schedule_item code

* pep8 fixes

* Download with extract_only and parameter checking (tableau#143)

* Add a new decorator that checks parameters against the version. Used with the @api decorator.
* Add extract_only flags to workbooks and data sources, protected behind v2.5 flag

* Correct the path to extract refresh tasks

* fixing missed pep8 failure

* adding runNow to the interface

* fixing pep8 issues

* Add header documentation to the sample.

* addressing tyler's feedback
bryceglarsen pushed a commit to bryceglarsen/server-client-python that referenced this pull request Dec 28, 2023
* Fix tableau#117 by only attempting files with the right extension inside the archive (tableau#118)

* Commenting and Docstring cleanup. A few very small code cleanups (tableau#120)

Add docstrings and remove clutter. I also made some very tiny tweaks to some code for clarity.

* Small cleanups for various editors. Play nice with built in test-runners (tableau#121)

* Add Py36, update travis to use pycodestyle (tableau#124)

* Add `initial sql` and `query band` support (tableau#123)

Addresses tableau#109 and tableau#110

* Prep for release of 0.6 (tableau#125)

* Prep for release of 0.6

* wordsmithing the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants