run long requests on second thread #1212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added a thread for the request, so we can continue giving progress updates on the UI added tests - could do with more
Also begins extracting constants for user editing
Configure it centrally. Still needs work to let the calling user configure it.
|
Note for review: this does contain 78 files, but |
| @@ -262,7 +271,11 @@ def publish( | |||
|
|
|||
| # Determine if chunking is required (64MB is the limit for single upload method) | |||
| if file_size >= FILESIZE_LIMIT: | |||
| logger.info("Publishing {0} to server with chunking method (datasource over 64MB)".format(filename)) | |||
| logger.info( | |||
| "Publishing {} to server with chunking method (datasource over {}MB, chunk size {}MB)".format( | |||
There was a problem hiding this comment.
Are FILESIZE_LIMIT and CHUNK_SIZE in bytes, not MB?
| logger.debug("{} Waiting....".format(datetime.timestamp())) | ||
| if minutes % 5 == 0 and seconds >= 60: | ||
| logger.info("[{}] Waiting ({} minutes so far) for request to {}".format(datetime.timestamp(), minutes, url)) | ||
| elif minutes % 1 == 0 and seconds >= 60: |
There was a problem hiding this comment.
Was this supposed to be minutes == 1?
There was a problem hiding this comment.
no, originally I was just logging every minute and then I added the longer message every 5 minutes and borked the checks
jacalata
force-pushed
the
jac/tfs-1504654-giant-publishing
branch
from
c2af35f to
cbba950
Compare
anyoung-tableau
approved these changes
Apr 19, 2023
jacalata
added a commit
that referenced
this pull request
Sep 22, 2023
* run long requests on second thread * improve chunked upload requests * begin extracting constants for user editing * centrally configured logger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a thread for the request, so we can continue giving progress updates on the UI while downloading.
added tests - could do with more
Was not able to repro the original issue (ran into other problems with a large file) so this may not help, but it should at least capture more logs of the failure.